Expose open and close methods on InfoWindow #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for vue3-google-map pending review.Visit the deploys page to approve it
|
HusamElbashir
approved these changes
Feb 7, 2023
|
LGTM |
|
We could even push it further and add a vModel for the open close state |
|
@husamibrahim Thank you for merging this. Any plans on when it will be tagged as a release? |
|
How do i open and close infoWindow now? |
|
Released in |
Hello! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently quite hard to open or close an infowindow as it requires the map from the
<GoogleMap>and a ref on the<Marker>and another ref on the<InfoWindow>But the infowindow already has all those info available and just needs to expose them